fix(Bigtable): ensure RowRanges are set on retry#8224
Merged
Conversation
product-auto-label
Bot
added
the
api: bigtable
bshaffer
commented
Apr 14, 2025
mutianf
reviewed
May 1, 2025
mutianf
reviewed
May 19, 2025
mutianf
previously approved these changes
May 19, 2025
cy-yun
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/391904535
This PR ensures the conformance tests pass for
TestReadRows_Retry_PausedScanTestReadRows_Retry_LastScannedRowIt fixes this by using
ReadRowsResponse::getLastScannedRowKeyand by usingReadRowsRequest::setEndKeyOpeninstead ofReadRowsRequest::setStartKeyOpenwhenReadRowsRequest::getReversed()is true.NOTE: While these changes pass all tests, we should discuss these changes with someone from the Bigtable team to be sure they're being used correctly.