-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Description
Determine this is the right repository
- I determined this is the correct repository in which to report this feature request.
Summary of the feature request
I would like to define a shared protofile that uses the import "google/longrunning/operations.proto"; import and build it using for use in two services:
- Java based: this import works fine
- Python based: this import does not work with the
googleapis-common-protospackage, because there the same file is calledoperations_proto.proto.
Currently the only workaround to make Python work is to change the import to import "google/longrunning/operations_proto.proto"; but that breaks the Java version using the proto file.
I wonder why the file is named differently in the Python version of googleapis-common-protos and is not consistent with the other packages. This makes sharing the proto files across languages problematic. Would it be possible to align it, please?
Desired code experience
current:
import "google/longrunning/operations_proto.proto";
message FooRequest {
}
service Foo {
rpc ProvisionFoo(FooRequest) returns (google.longrunning.Operation) {
option (google.longrunning.operation_info) = {
metadata_type: "Something"
response_type: "SomethingElse"
};
}
}
expected:
import "google/longrunning/operations.proto";
message FooRequest {
}
service Foo {
rpc ProvisionFoo(FooRequest) returns (google.longrunning.Operation) {
option (google.longrunning.operation_info) = {
metadata_type: "Something"
response_type: "SomethingElse"
};
}
}
Expected results
No response
API client name and version
No response
Use case
No response
Additional context
The file name used to be correct in version 1.66.0, then the file disappeared in 1.67.0 and reappeared with the wrong name in 1.68.1 in the #13614 PR.