fix(sqlalchemy-spanner): register TOKENLIST in _type_map for reflection - #17911
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for mapping the Spanner 'TOKENLIST' type to SQLAlchemy's 'types.String' and includes a test to verify this mapping. The review feedback suggests optimizing the new test by inheriting from 'unittest.TestCase' instead of 'MockServerTestBase' to avoid unnecessary overhead, since the test only asserts static type mapping and does not require a mock database server.
olavloite
approved these changes
Jul 27, 2026
olavloite
left a comment
olavloite
left a comment
Contributor
There was a problem hiding this comment.
The change LGTM, but the suggestion from Gemini for the test should indeed be applied.
Table reflection raises KeyError: 'TOKENLIST' whenever a table containing a TOKENLIST column is reflected. Fixes this issue by registering "TOKENLIST": types.String in _type_map in google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py.
sakthivelmanii
force-pushed
the
fix-spanner-reflection-tokenlist-type
branch
from
July 27, 2026 15:12
0702c7d to
527f180
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table reflection raises KeyError: 'TOKENLIST' whenever a table containing a TOKENLIST column is reflected.
Fixes this issue by registering "TOKENLIST": types.String in _type_map in google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕