fix(google-auth-oauthlib): prevent port re-use on windows - #18166
Merged
daniel-sanche merged 9 commits intoAug 21, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new unit test, test_run_local_server_exclusive_port_binding, to verify that no other process or socket can bind to the port while run_local_server is active. The review feedback points out a critical issue where an assertion failure inside the ThreadPoolExecutor context can cause the test suite to hang indefinitely because the context manager blocks waiting for the server thread to finish. It is recommended to wrap the assertions in a try...finally block to guarantee that the server thread is unblocked and terminated cleanly.
parthea
changed the title
daniel-sanche
changed the title
This was referenced Aug 19, 2026
daniel-sanche
marked this pull request as ready for review
August 20, 2026 00:14
ohmayr
approved these changes
Aug 21, 2026
hebaalazzeh
pushed a commit
that referenced
this pull request
Aug 21, 2026
CI Jobs have logic to find the merge base, and compare changes against it to determine which packages have changed in the PR Previously, it used a fetch-depth of 2, to avoid downloading the whole monorepo history. This could cause issues finding the base, which would trigger a full test run (see #18166) This PR does a full fetch (fetch-depth: 0), but filters out blobs, so the clone and comparison is still fast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building off of #18137
The commit history has test results running against windows, using a temporary GitHub Action workflow. It was removed from the latest commit