feat(firestore): configure gRPC message length limits for large documents - #18220
Conversation
There was a problem hiding this comment.
Code Review
This pull request configures unlimited gRPC send and receive message sizes for Firestore clients, including emulator channels, to support handling large documents. It also adds system tests for both synchronous and asynchronous operations with large documents on Enterprise DB, along with corresponding unit test updates. The review feedback highlights a critical issue in the new asynchronous system tests: passing the asynchronous doc_ref.delete coroutine to a synchronous cleanup fixture will cause cleanup to fail and raise a RuntimeWarning. It is recommended to use try...finally blocks to explicitly await the deletion of the documents.
575e622 to
4b979b4
Compare
…matching Go PR 14684
parthea
left a comment
There was a problem hiding this comment.
LGTM, but holding off on formal approval. Please could you address the feedback from gemini-code-assist?
grpc.max_send_message_lengthandgrpc.max_receive_message_lengthoptions on production and emulator gRPC channels.test_base_client.pyto assert gRPC message size options.