Skip to content

feat(firestore): configure gRPC message length limits for large documents - #18220

Merged
ohmayr merged 4 commits into
mainfrom
support-larger-docs-firestore
Sep 1, 2026
Merged

feat(firestore): configure gRPC message length limits for large documents#18220
ohmayr merged 4 commits into
mainfrom
support-larger-docs-firestore

Conversation

@ohmayr

@ohmayr ohmayr commented Aug 25, 2026

Copy link
Copy Markdown
Contributor
  • Configure grpc.max_send_message_length and grpc.max_receive_message_length options on production and emulator gRPC channels.
  • Update unit tests in test_base_client.py to assert gRPC message size options.
  • Add system tests for large document CRUD and pipeline execution across sync and async clients.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures unlimited gRPC send and receive message sizes for Firestore clients, including emulator channels, to support handling large documents. It also adds system tests for both synchronous and asynchronous operations with large documents on Enterprise DB, along with corresponding unit test updates. The review feedback highlights a critical issue in the new asynchronous system tests: passing the asynchronous doc_ref.delete coroutine to a synchronous cleanup fixture will cause cleanup to fail and raise a RuntimeWarning. It is recommended to use try...finally blocks to explicitly await the deletion of the documents.

Comment thread packages/google-cloud-firestore/tests/system/test_system_async.py
Comment thread packages/google-cloud-firestore/tests/system/test_system_async.py
@ohmayr
ohmayr force-pushed the support-larger-docs-firestore branch from 575e622 to 4b979b4 Compare August 25, 2026 19:30
@ohmayr
ohmayr marked this pull request as ready for review August 25, 2026 20:17
@ohmayr
ohmayr requested a review from a team as a code owner August 25, 2026 20:18

@parthea parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but holding off on formal approval. Please could you address the feedback from gemini-code-assist?

Comment thread packages/google-cloud-firestore/tests/unit/v1/test_base_client.py
Comment thread packages/google-cloud-firestore/tests/system/test_system_async.py Outdated
Comment thread packages/google-cloud-firestore/tests/system/test_system_async.py
@ohmayr
ohmayr merged commit 6e0f1d9 into main Sep 1, 2026
46 checks passed
@ohmayr
ohmayr deleted the support-larger-docs-firestore branch September 1, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants