chore: polish post processing step used for librarian client library generation#14206
Merged
chore: polish post processing step used for librarian client library generation#14206
Conversation
parthea
force-pushed
the
polish-post-processing
branch
from
450f66c to
4a6f41f
Compare
ohmayr
reviewed
Aug 12, 2025
|
|
||
| try: | ||
| import synthtool | ||
| from synthtool import gcp |
Contributor
There was a problem hiding this comment.
can we remove this line if it's not needed?
ohmayr
reviewed
Aug 12, 2025
ohmayr
previously approved these changes
Aug 12, 2025
ohmayr
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new functions
_copy_files_needed_for_post_processingand_clean_up_files_after_post_processing._copy_files_needed_for_post_processing- This function is used to copy files from theinputdirectory . Specifically,.repo-metadata.jsonandscripts/client-post-processingare needed as part of client library generation._clean_up_files_after_post_processing- This function removes files which should not be part of the generated code because it would create an unnecessary diff. The files omitted are:CHANGELOG.mddocs/CHANGELOG.mddocs/README.rstscripts/client-post-processing/*.yaml**/gapic_version.pysamples/generated_samples/snippet_metadata*.json