fix: fix mypy errors in google-cloud-monitoring-dashboards/google/monitoring

[parthea]

Towards #15104

This is needed to unblock #15457 . See the following mypy failure for google-cloud-monitoring-dashboards

See follow up issue #11858 to remove the google/monitoring folder which is no longer being generated automatically.

See follow up issue googleapis/proto-plus-python#558 for the prerelease presubmit failure.

.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/types/service.py:19: error: Name "proto" is not defined  [name-defined]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/types/drilldowns.py:19: error: Name "proto" is not defined  [name-defined]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/base.py:49: error: Incompatible default for argument "credentials" (default has type "None", argument has type "Credentials")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/base.py:49: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/base.py:49: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:52: error: Incompatible default for argument "credentials" (default has type "None", argument has type "Credentials")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:52: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:52: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:53: error: Incompatible default for argument "credentials_file" (default has type "None", argument has type "str")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:53: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:53: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:54: error: Incompatible default for argument "scopes" (default has type "None", argument has type "Sequence[str]")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:54: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:54: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:56: error: Incompatible default for argument "api_mtls_endpoint" (default has type "None", argument has type "str")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:56: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:56: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:57: error: Incompatible default for argument "client_cert_source" (default has type "None", argument has type "Callable[[], tuple[bytes, bytes]]")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:57: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:57: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:97: error: Incompatible types in assignment (expression has type "bool", variable has type "Credentials")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:115: error: Function "client_cert_source" could always be true in boolean context  [truthy-function]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:148: error: Incompatible default for argument "credentials" (default has type "None", argument has type "Credentials")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:148: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:148: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:149: error: Incompatible default for argument "credentials_file" (default has type "None", argument has type "str")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:149: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc.py:149: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:54: error: Incompatible default for argument "credentials" (default has type "None", argument has type "Credentials")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:54: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:54: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:95: error: Incompatible default for argument "credentials" (default has type "None", argument has type "Credentials")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:95: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:95: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:99: error: Incompatible default for argument "api_mtls_endpoint" (default has type "None", argument has type "str")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:99: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/transports/grpc_asyncio.py:99: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/client.py:474: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:55: error: Argument 1 to "get_transport_class" of "DashboardsServiceClientMeta" has incompatible type "type[type[DashboardsServiceClient]]"; expected "DashboardsServiceClientMeta"  [arg-type]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:61: error: Incompatible default for argument "credentials" (default has type "None", argument has type "Credentials")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:61: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:61: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:63: error: Module "google.api_core.client_options" is not valid as a type  [valid-type]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:63: note: Perhaps you meant to use a protocol matching the module structure?
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:103: error: Incompatible default for argument "request" (default has type "None", argument has type "CreateDashboardRequest")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:103: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:103: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:105: error: Incompatible default for argument "retry" (default has type "_MethodDefault", argument has type "Retry")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:106: error: Incompatible default for argument "timeout" (default has type "None", argument has type "float")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:106: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:106: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:164: error: Incompatible default for argument "request" (default has type "None", argument has type "ListDashboardsRequest")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:164: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:164: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:166: error: Incompatible default for argument "retry" (default has type "_MethodDefault", argument has type "Retry")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:167: error: Incompatible default for argument "timeout" (default has type "None", argument has type "float")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:167: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:167: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:234: error: Incompatible default for argument "request" (default has type "None", argument has type "GetDashboardRequest")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:234: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:234: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:236: error: Incompatible default for argument "retry" (default has type "_MethodDefault", argument has type "Retry")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:237: error: Incompatible default for argument "timeout" (default has type "None", argument has type "float")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:237: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:237: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:295: error: Incompatible default for argument "request" (default has type "None", argument has type "DeleteDashboardRequest")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:295: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:295: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:297: error: Incompatible default for argument "retry" (default has type "_MethodDefault", argument has type "Retry")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:298: error: Incompatible default for argument "timeout" (default has type "None", argument has type "float")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:298: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:298: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:345: error: Incompatible default for argument "request" (default has type "None", argument has type "UpdateDashboardRequest")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:345: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:345: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:347: error: Incompatible default for argument "retry" (default has type "_MethodDefault", argument has type "Retry")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:348: error: Incompatible default for argument "timeout" (default has type "None", argument has type "float")  [assignment]
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:348: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
.nox/mypy-3-14/lib/python3.14/site-packages/google/monitoring/dashboard_v1/services/dashboards_service/async_client.py:348: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase

[gemini-code-assist]

Summary of Changes

Hello @parthea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a series of 'mypy' type-checking errors within the 'google-cloud-monitoring-dashboards' library. The changes primarily involve enhancing type hint accuracy for optional parameters in client and transport constructors and method signatures, aligning with stricter type-checking rules. Additionally, it removes two outdated and unused type definition files that were contributing to 'mypy' failures, streamlining the codebase and improving its maintainability.

Highlights

• Mypy Type Hint Corrections: Explicitly added 'Optional' to numerous type hints for parameters that accept 'None' as a default, resolving 'mypy's 'no_implicit_optional' errors across client and transport files.
• Import Statement Refinements: Adjusted import statements for 'ClientOptions' to be more explicit, fixing 'mypy' errors related to module type validity.
• Removal of Obsolete Files: Deleted 'drilldowns.py' and 'service.py' from the 'google/monitoring/dashboard_v1/types' directory, which were no longer automatically generated and were causing 'mypy' errors.
• 'OptionalRetry' Type Alias: Introduced a new 'OptionalRetry' type alias to simplify type hints for retry parameters, accommodating 'AsyncRetry', '_MethodDefault', and 'None'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively resolves a number of mypy errors, primarily related to the strict no_implicit_optional setting. The changes are well-executed and improve the overall type safety and correctness of the codebase. Key fixes include explicitly using Optional for parameters that can be None, correcting invalid type assignments, fixing docstring inaccuracies, and removing obsolete files that were causing build failures. The code is now cleaner and more robust against type-related issues.

[daniel-sanche]

LGTM