fix: fix mypy errors #15494
fix: fix mypy errors #15494
Conversation
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves existing Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
parthea
force-pushed
the
fix-google-cloud-monitoring-mypy
branch
from
4d28728 to
f122d4d
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes mypy errors by adding a type: ignore for an optional pandas import and including pandas-stubs in the mypy test environment. The changes are correct, but I've suggested a cleaner pattern for handling the optional import that avoids using type: ignore for better code clarity and maintainability.
| import pandas | ||
| except ImportError: # pragma: NO COVER | ||
| pandas = None | ||
| pandas = None # type: ignore[assignment] |
There was a problem hiding this comment.
While using type: ignore is a valid way to resolve the mypy error, a more modern and clearer approach for handling optional dependencies is to use typing.TYPE_CHECKING. This avoids the need to suppress errors.
You can achieve this by:
- Adding an import guard at the top of the file:
from typing import TYPE_CHECKING
if TYPE_CHECKING:
import pandas- Removing the
# type: ignorefrom this line. Thetry...exceptblock for the import can remain as it is for the runtime logic.
This pattern makes the dependency explicit for static analysis tools while correctly handling its absence at runtime, improving overall code clarity and maintainability.
There was a problem hiding this comment.
This suggestion results in the following error. The # type: ignore is needed based on local testing
.nox/mypy-3-14/lib/python3.14/site-packages/google/cloud/monitoring_v3/_dataframe.py:27: error: Incompatible types in assignment (expression has type "None", variable has type Module) [assignment]
Found 1 error in 1 file (checked 93 source files)
nox > Command mypy -p google failed with exit code 1
nox > Session mypy-3.14 failed.
2 participants
Towards #15104
This is needed to unblock #15457 .
See follow up issue googleapis/proto-plus-python#558 for the
prereleasepresubmit failure.See the following mypy failure for
google-cloud-monitoringSee the following mypy failure for
google-cloud-org-policySee the following mypy failure for
google-cloud-speechSee the following failure for
google-cloud-vision