Skip to content

chore(multiple): format handwritten code#15617

Merged
jskeet merged 3 commits intogoogleapis:mainfrom
jskeet:format-automl
Feb 26, 2026
Merged

chore(multiple): format handwritten code#15617
jskeet merged 3 commits intogoogleapis:mainfrom
jskeet:format-automl

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Feb 26, 2026

This was just a matter of running "nox -s format --no-venv --no-install" in three packages. These files aren't generated by legacylibrarian, so weren't formatted by it.

This was just a matter of running "nox -s format --no-venv
--no-install". These files aren't generated by legacylibrarian, so
weren't formatted by it.
@jskeet jskeet requested review from a team as code owners February 26, 2026 12:41
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @jskeet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses code consistency by applying standardized formatting to unit test files in the google-cloud-automl package. The changes ensure that import statements within these files adhere to a consistent order, which was previously not enforced by legacylibrarian for these specific files.

Highlights

  • Code Formatting: Applied consistent formatting to unit test files within the google-cloud-automl package by reordering import statements.
Changelog
  • packages/google-cloud-automl/tests/unit/test_gcs_client_v1beta1.py
    • Reordered import statements to comply with formatting standards.
  • packages/google-cloud-automl/tests/unit/test_tables_client_v1beta1.py
    • Reordered import statements to comply with formatting standards.
Activity
  • No human activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jskeet jskeet enabled auto-merge (squash) February 26, 2026 12:41
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request primarily focuses on reformatting unit test files by reordering import statements. This appears to be a standard formatting task executed by nox -s format, which helps maintain code consistency across the codebase. The changes are purely stylistic and do not introduce any functional modifications or issues.

@jskeet jskeet changed the title chore(automl): format unit tests chore(multiple): format handwritten code Feb 26, 2026
@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Feb 26, 2026

The speech one is slightly odd, admittedly - that should be generated, so I'm not quite sure why the formatting is wrong.

@jskeet jskeet disabled auto-merge February 26, 2026 13:41
@jskeet jskeet enabled auto-merge (squash) February 26, 2026 13:41
Comment on lines 23 to 27
import pytest
from google.api_core import exceptions
from google.auth.credentials import AnonymousCredentials

from google.cloud import automl_v1beta1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import pytest
from google.api_core import exceptions
from google.auth.credentials import AnonymousCredentials
from google.cloud import automl_v1beta1
import pytest
from google.api_core import exceptions
from google.auth.credentials import AnonymousCredentials
from google.cloud import automl_v1beta1

Comment on lines 21 to 26
import pytest
from google.api_core import exceptions
from google.auth.credentials import AnonymousCredentials
from google.protobuf import struct_pb2 as struct

from google.cloud import automl_v1beta1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import pytest
from google.api_core import exceptions
from google.auth.credentials import AnonymousCredentials
from google.protobuf import struct_pb2 as struct
from google.cloud import automl_v1beta1
import pytest
from google.api_core import exceptions
from google.auth.credentials import AnonymousCredentials
from google.protobuf import struct_pb2 as struct
from google.cloud import automl_v1beta1

@jskeet jskeet merged commit e0426dc into googleapis:main Feb 26, 2026
27 checks passed
@jskeet jskeet deleted the format-automl branch February 26, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants