feat: add support for hparam_range and hparam_candidates to bigframes.bigquery.create_model#16640
Open
tswast wants to merge 3 commits intofeat-bigframes-create-model-expression-options-15193413976404138758from
Conversation
…rames.bigquery.create_model`
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces hparam_range and hparam_candidates functions to the bigframes.bigquery module, enabling support for hyperparameter tuning in BigQuery ML model creation. These functions wrap the HPARAM_RANGE and HPARAM_CANDIDATES SQL functions. The review feedback recommends simplifying the type hints for these new functions, noting that in Python type annotations, float already encompasses int.
packages/bigframes/bigframes/bigquery/_operations/mathematical.py
Outdated
Show resolved
Hide resolved
packages/bigframes/bigframes/bigquery/_operations/mathematical.py
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes internal issue b/501171054
🦕