Skip to content

chore: migration batch 3#16660

Merged
jskeet merged 48 commits intogoogleapis:mainfrom
jskeet:batch-3
Apr 15, 2026
Merged

chore: migration batch 3#16660
jskeet merged 48 commits intogoogleapis:mainfrom
jskeet:batch-3

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 15, 2026

Regenerated packages:

  • google-cloud-build
  • google-cloud-capacityplanner
  • google-cloud-certificate-manager
  • google-cloud-ces
  • google-cloud-channel
  • google-cloud-chronicle
  • google-cloud-cloudcontrolspartner
  • google-cloud-cloudsecuritycompliance
  • google-cloud-commerce-consumer-procurement
  • google-cloud-common
  • google-cloud-confidentialcomputing
  • google-cloud-config
  • google-cloud-configdelivery
  • google-cloud-contact-center-insights
  • google-cloud-containeranalysis
  • google-cloud-contentwarehouse
  • google-cloud-core
  • google-cloud-databasecenter
  • google-cloud-datacatalog
  • google-cloud-datacatalog-lineage
  • google-cloud-dataflow-client
  • google-cloud-dataform
  • google-cloud-data-fusion
  • google-cloud-datalabeling
  • google-cloud-dataproc-metastore
  • google-cloud-data-qna
  • google-cloud-datastream
  • google-cloud-deploy
  • google-cloud-developerconnect
  • google-cloud-devicestreaming
  • google-cloud-discoveryengine
  • google-cloud-dlp
  • google-cloud-dms
  • google-cloud-documentai
  • google-cloud-documentai-toolbox
  • google-cloud-domains
  • google-cloud-edgecontainer
  • google-cloud-edgenetwork
  • google-cloud-enterpriseknowledgegraph
  • google-cloud-essential-contacts
  • google-cloud-eventarc
  • google-cloud-eventarc-publishing
  • google-cloud-filestore
  • google-cloud-financialservices
  • google-cloud-functions
  • google-cloud-gdchardwaremanagement
  • google-cloud-geminidataanalytics
  • google-cloud-gke-backup

jskeet added 26 commits April 15, 2026 14:14
@jskeet jskeet requested a review from a team as a code owner April 15, 2026 14:29
@jskeet jskeet requested a review from parthea April 15, 2026 14:29
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes and reformats .repo-metadata.json files across numerous Google Cloud Python packages, primarily updating fields such as api_id and api_shortname while adjusting indentation. The review feedback identifies a placeholder "null " description in the Cloud Security Compliance package and a leading space in the Contact Center Insights metadata. Furthermore, suggestions are provided to fix reStructuredText formatting in the Dataform README files, where improper line breaks could interfere with correct paragraph rendering.

"product_documentation": "https://cloud.google.com/security-command-center/docs/compliance-manager-overview",
"release_level": "preview",
"repo": "googleapis/google-cloud-python"
"api_description": "null ",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The api_description value "null " appears to be a placeholder or an incorrect stringification of a null value. It should be replaced with a meaningful description or removed if no description is available, consistent with other packages in this repository (e.g., google-cloud-ces).

"product_documentation": "https://cloud.google.com/contact-center/insights/docs",
"release_level": "stable",
"repo": "googleapis/google-cloud-python"
"api_description": " helps users detect and visualize patterns in their contact center data.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The api_description contains an unnecessary leading space.

Suggested change
"api_description": " helps users detect and visualize patterns in their contact center data.",
"api_description": "helps users detect and visualize patterns in their contact center data.",

Comment on lines +6 to +7
`Cloud Dataform`_: Service to develop, version control, and operationalize SQL pipelines in
BigQuery.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The description is split across two lines with the second line starting at column 0. In reStructuredText, this is interpreted as two separate paragraphs rather than a single continuous description. It should be kept on a single line or the second line should be indented to align with the first.

Suggested change
`Cloud Dataform`_: Service to develop, version control, and operationalize SQL pipelines in
BigQuery.
`Cloud Dataform`_: Service to develop, version control, and operationalize SQL pipelines in BigQuery.

Comment on lines +6 to +7
`Cloud Dataform`_: Service to develop, version control, and operationalize SQL pipelines in
BigQuery.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The description is split across two lines with the second line starting at column 0. In reStructuredText, this is interpreted as two separate paragraphs rather than a single continuous description. It should be kept on a single line or the second line should be indented to align with the first.

Suggested change
`Cloud Dataform`_: Service to develop, version control, and operationalize SQL pipelines in
BigQuery.
`Cloud Dataform`_: Service to develop, version control, and operationalize SQL pipelines in BigQuery.

@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Apr 15, 2026

Will look at the Kokoro failure when I get a chance.

@parthea
Copy link
Copy Markdown
Contributor

parthea commented Apr 15, 2026

It was a single test failure. It could be a flaky test. We can file an issue to follow up on it. I retried the kokoro job to see if the issue persists to gather information for the bug report. We may want to remove the package google-cloud-error-reporting from the PR while we investigate.

nox > py.test tests/unit
============================= test session starts ==============================
platform linux -- Python 3.14.3, pytest-9.0.3, pluggy-1.6.0
rootdir: /tmpfs/src/github/google-cloud-python/packages/google-cloud-error-reporting
configfile: pytest.ini
plugins: cov-7.1.0, asyncio-1.3.0
asyncio: mode=Mode.STRICT, debug=False, asyncio_default_fixture_loop_scope=None, asyncio_default_test_loop_scope=function
collected 511 items

tests/unit/gapic/errorreporting_v1beta1/test_error_group_service.py .... [  0%]
........................................................................ [ 14%]
........................................................................ [ 28%]
..............                                                           [ 31%]
tests/unit/gapic/errorreporting_v1beta1/test_error_stats_service.py .... [ 32%]
........................................................................ [ 46%]
........................................................................ [ 60%]
..................................................                       [ 70%]
tests/unit/gapic/errorreporting_v1beta1/test_report_errors_service.py .. [ 70%]
........................................................................ [ 84%]
............................................................             [ 96%]
tests/unit/test__gapic.py ...                                            [ 97%]
tests/unit/test__logging.py ...                                          [ 97%]
tests/unit/test_client.py F........                                      [ 99%]
tests/unit/test_packaging.py .                                           [ 99%]
tests/unit/test_util.py .                                                [100%]

=================================== FAILURES ===================================
________________________ TestClient.test_ctor_defaults _________________________

self = <tests.unit.test_client.TestClient testMethod=test_ctor_defaults>
default_mock = <MagicMock name='_determine_default_project' id='140314437456560'>

    @mock.patch("google.cloud.client._determine_default_project")
    def test_ctor_defaults(self, default_mock):
        from google.api_core.client_info import ClientInfo
    
        credentials = _make_credentials()
        default_mock.return_value = "foo"
        client = self._make_one(credentials=credentials)
        self.assertEqual(client.service, client.DEFAULT_SERVICE)
        self.assertEqual(client.version, None)
        self.assertIsInstance(client._client_info, ClientInfo)
>       default_mock.assert_called_once_with(None)

[tests/unit/test_client.py:64](https://cs.corp.google.com/piper///depot/google3/tests/unit/test_client.py?l=64): 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

_mock_self = <MagicMock name='_determine_default_project' id='140314437456560'>
args = (None,), kwargs = {}
self = <MagicMock name='_determine_default_project' id='140314437456560'>
msg = "Expected '_determine_default_project' to be called once. Called 0 times."

    def assert_called_once_with(_mock_self, *args, **kwargs):
        """assert that the mock was called exactly once and that that call was
        with the specified arguments."""
        self = _mock_self
        if not self.call_count == 1:
            msg = ("Expected '%s' to be called once. Called %s times.%s"
                   % (self._mock_name or 'mock',
                      self.call_count,
                      self._calls_repr()))
>           raise AssertionError(msg)
E           AssertionError: Expected '_determine_default_project' to be called once. Called 0 times.

@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Apr 15, 2026

Removed google-cloud-datastore

@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Apr 15, 2026

Removed google-cloud-error-reporting as well

@jskeet jskeet merged commit 53c0c91 into googleapis:main Apr 15, 2026
30 checks passed
chalmerlowe pushed a commit that referenced this pull request Apr 17, 2026
Regenerated packages:

- google-cloud-build
- google-cloud-capacityplanner
- google-cloud-certificate-manager
- google-cloud-ces
- google-cloud-channel
- google-cloud-chronicle
- google-cloud-cloudcontrolspartner
- google-cloud-cloudsecuritycompliance
- google-cloud-commerce-consumer-procurement
- google-cloud-common
- google-cloud-confidentialcomputing
- google-cloud-config
- google-cloud-configdelivery
- google-cloud-contact-center-insights
- google-cloud-containeranalysis
- google-cloud-contentwarehouse
- google-cloud-core
- google-cloud-databasecenter
- google-cloud-datacatalog
- google-cloud-datacatalog-lineage
- google-cloud-dataflow-client
- google-cloud-dataform
- google-cloud-data-fusion
- google-cloud-datalabeling
- google-cloud-dataproc-metastore
- google-cloud-data-qna
- google-cloud-datastream
- google-cloud-deploy
- google-cloud-developerconnect
- google-cloud-devicestreaming
- google-cloud-discoveryengine
- google-cloud-dlp
- google-cloud-dms
- google-cloud-documentai
- google-cloud-documentai-toolbox
- google-cloud-domains
- google-cloud-edgecontainer
- google-cloud-edgenetwork
- google-cloud-enterpriseknowledgegraph
- google-cloud-essential-contacts
- google-cloud-eventarc
- google-cloud-eventarc-publishing
- google-cloud-filestore
- google-cloud-financialservices
- google-cloud-functions
- google-cloud-gdchardwaremanagement
- google-cloud-geminidataanalytics
- google-cloud-gke-backup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants