Skip to content

chore: complete bigframes migration#16682

Merged
parthea merged 2 commits intogoogleapis:mainfrom
jskeet:reformat-bigframes
Apr 16, 2026
Merged

chore: complete bigframes migration#16682
parthea merged 2 commits intogoogleapis:mainfrom
jskeet:reformat-bigframes

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 16, 2026

  • Reformat with nox
  • Enable generation with librarian
  • Regenerate with librarian

@jskeet jskeet requested a review from parthea April 16, 2026 07:10
@jskeet jskeet requested review from a team as code owners April 16, 2026 07:10
@jskeet jskeet requested review from shuoweil and removed request for a team April 16, 2026 07:10
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the bigframes library to a stable release level, updates its metadata, and adds a detailed README.rst documentation file. Review feedback suggests consolidating split imports from the same module in loader.py for better idiomatic consistency and correcting a typo in the documentation.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/bigframes/bigframes/session/loader.py (55-60)

medium

The imports from google.cloud.bigquery_storage_v1 have been split into two separate blocks. It is more idiomatic in Python to group imports from the same module together in a single block.

from google.cloud.bigquery_storage_v1 import (
    types as bq_storage_types,
    writer as bq_storage_writer,
)
References
  1. PEP-8 recommends grouping imports from the same module together to improve readability and organization. (link)

packages/bigframes/docs/README.rst (40)

medium

There is a typo and redundant word in this line: "environment enviroment".

   for your local development environment.

@parthea parthea self-assigned this Apr 16, 2026
@parthea parthea merged commit b1ea082 into googleapis:main Apr 16, 2026
30 checks passed
chalmerlowe pushed a commit that referenced this pull request Apr 17, 2026
- Reformat with nox
- Enable generation with librarian
- Regenerate with librarian
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants