chore: complete migration of googleapis-common-protos to librarian#16688
Merged
parthea merged 3 commits intogoogleapis:mainfrom Apr 16, 2026
Merged
chore: complete migration of googleapis-common-protos to librarian#16688parthea merged 3 commits intogoogleapis:mainfrom
parthea merged 3 commits intogoogleapis:mainfrom
Conversation
Stop skipping generation, and add a new post-processing replacement so that existing files which aren't currently being regenerated don't end up with extra copyright statements.
Command: `nox -s format --no-install --no-venv`
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a post-processing configuration to prevent duplicate copyright notices in generated Python files and updates metadata and documentation for the googleapis-common-protos package. Additionally, it reorders imports in several generated protobuf files. A critical issue was identified in the new YAML configuration where a literal backslash-n character in a block scalar may prevent the regex from matching the intended code pattern.
parthea
approved these changes
Apr 16, 2026
chalmerlowe
pushed a commit
that referenced
this pull request
Apr 17, 2026
…16688) - Adds a string replacement to avoid double copyright notices while we're (still) not generating google/gapic and google/longrunning - Removes the skip_generate from librarian.yaml - Reformats with nox - Regenerates Fixes googleapis/librarian#5334
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/librarian#5334