chore: complete migration of google-cloud-storage#16705
Merged
jskeet merged 1 commit intogoogleapis:mainfrom Apr 21, 2026
Merged
chore: complete migration of google-cloud-storage#16705jskeet merged 1 commit intogoogleapis:mainfrom
jskeet merged 1 commit intogoogleapis:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the configuration and metadata for the Google Cloud Storage library. Key changes include removing the skip_generate flag in librarian.yaml, reordering and cleaning up fields in .repo-metadata.json (specifically removing requires_billing and codeowner_team), and a minor comment update in noxfile.py. I have no feedback to provide.
Contributor
|
Switching to draft until checks are green |
Contributor
Contributor
Author
|
Will do as soon as my current generation task is done. It's all blocked on that :( |
ca5f7a0 to
28d8b67
Compare
Contributor
Author
|
@parthea Rebases and repushed. Let's see what happens. |
parthea
approved these changes
Apr 21, 2026
Contributor
|
@jskeet PTAL at the conflict |
Removed skip_generate and regenerated with Librarian.
28d8b67 to
0dc575c
Compare
Contributor
Author
|
Rebased again, repushed... |
parthea
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed skip_generate and regenerated with Librarian.