chore: enable generation for google-cloud-dataplex#16723
chore: enable generation for google-cloud-dataplex#16723parthea merged 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the google-cloud-dataplex package by enabling library generation in librarian.yaml, updating the issue tracker URL in .repo-metadata.json, and adjusting JSON indentation. In noxfile.py, the -W flag was removed from the sphinx-build command; the reviewer recommends restoring this flag to ensure documentation warnings continue to be treated as errors for consistency and quality.
| session.run( | ||
| "sphinx-build", | ||
| "-W", # warnings as errors | ||
| "-T", # show full traceback on exception |
There was a problem hiding this comment.
The -W flag (warnings as errors) was removed from the sphinx-build command. This flag ensures that any documentation warnings are treated as errors, which is crucial for maintaining documentation quality in CI. Please restore this flag to maintain consistency across the repository.
| "-T", # show full traceback on exception | |
| "-W", # warnings as errors | |
| "-T", # show full traceback on exception |
References
- Changes to shared configurations, like mypy flags, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
2 participants
No description provided.