chore: enable generation of google-cloud-dialogflow-cx #16724
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,16 @@ | ||
| { | ||
| "api_description": "Builds conversational interfaces (for example, chatbots, and voice-powered\napps and devices).", | ||
| "api_id": "dialogflow.googleapis.com", | ||
| "api_shortname": "dialogflow", | ||
| "client_documentation": "https://cloud.google.com/python/docs/reference/dialogflow-cx/latest", | ||
| "default_version": "v3", | ||
| "distribution_name": "google-cloud-dialogflow-cx", | ||
| "issue_tracker": "https://issuetracker.google.com/savedsearches/5300385", | ||
| "language": "python", | ||
| "library_type": "GAPIC_AUTO", | ||
| "name": "dialogflow-cx", | ||
| "name_pretty": "Dialogflow CX", | ||
| "product_documentation": "https://cloud.google.com/dialogflow/cx/docs", | ||
| "release_level": "stable", | ||
| "repo": "googleapis/google-cloud-python" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -390,7 +390,6 @@ def docs(session): | |||||||||||||
| shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True) | ||||||||||||||
| session.run( | ||||||||||||||
| "sphinx-build", | ||||||||||||||
| "-T", # show full traceback on exception | ||||||||||||||
|
Comment on lines
392
to
393
Contributor
There was a problem hiding this comment. The -W flag (warnings as errors) was removed from the sphinx-build command. This flag is important for maintaining documentation quality by ensuring that any syntax errors or broken references are caught during the build process. It should be restored, especially since the changes in the README files appear to introduce documentation warnings.
Suggested change
References
|
||||||||||||||
| "-N", # no colors | ||||||||||||||
| "-b", | ||||||||||||||
|
|
||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hyperlink target definition for
Dialogflow CXis incorrectly formatted. In reStructuredText, the syntax`Name`_: TextexpectsTextto be a URL. Providing a description instead will break the link and likely cause a Sphinx warning. The description should be placed on a separate line, and the link should point to the product documentation.