chore: enable generation for google-cloud-network-connectivity#16725
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables code generation for the Google Cloud Network Connectivity library, updates its repository metadata by removing the issue tracker field, and modifies the documentation build configuration. Feedback was provided regarding the removal of the -W flag in the noxfile.py, suggesting it be retained to ensure documentation quality and maintain consistency across shared configurations.
| session.run( | ||
| "sphinx-build", | ||
| "-W", # warnings as errors | ||
| "-T", # show full traceback on exception |
There was a problem hiding this comment.
The -W flag (warnings as errors) has been removed from the sphinx-build command. Changes to shared configurations should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests. It is recommended to keep this flag enabled to prevent malformed documentation from being published.
| "-T", # show full traceback on exception | |
| "-W", # warnings as errors | |
| "-T", # show full traceback on exception |
References
- Changes to shared configurations should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
2 participants
No description provided.