Skip to content

chore: enable generation for google-cloud-recaptcha-enterprise#16726

Merged
jskeet merged 1 commit intogoogleapis:mainfrom
jskeet:regenerate-google-cloud-recaptcha-enterprise
Apr 20, 2026
Merged

chore: enable generation for google-cloud-recaptcha-enterprise#16726
jskeet merged 1 commit intogoogleapis:mainfrom
jskeet:regenerate-google-cloud-recaptcha-enterprise

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 20, 2026

No description provided.

@jskeet jskeet requested a review from parthea April 20, 2026 14:34
@jskeet jskeet requested a review from a team as a code owner April 20, 2026 14:34
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables code generation for the reCAPTCHA Enterprise library, cleans up its repository metadata by removing the empty issue tracker field, and adjusts the documentation build configuration. Feedback was provided regarding the removal of the -W flag in the documentation build process, as repository rules require shared configurations to remain consistent unless changed globally.

session.run(
"sphinx-build",
"-W", # warnings as errors
"-T", # show full traceback on exception
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The -W flag (warnings as errors) has been removed from the sphinx-build command. This flag ensures that documentation is built without warnings. According to repository rules, changes to shared configurations should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests. Unless this is a repository-wide change, please retain the flag to prevent regressions in documentation quality.

Suggested change
"-T", # show full traceback on exception
"-W", # warnings as errors
"-T", # show full traceback on exception
References
  1. Changes to shared configurations, like mypy or sphinx flags, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.

@jskeet jskeet merged commit 5cb4a89 into googleapis:main Apr 20, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants