fix: propagate quota_project_id and api_endpoint in AsyncGrpcClient#16731
Merged
chandra-siri merged 2 commits intogoogleapis:mainfrom Apr 21, 2026
Merged
fix: propagate quota_project_id and api_endpoint in AsyncGrpcClient#16731chandra-siri merged 2 commits intogoogleapis:mainfrom
chandra-siri merged 2 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the AsyncGrpcClient to support custom API endpoints and quota project IDs by extracting these values from client_options and passing them to the transport's create_channel method. While the unit tests were updated to include the host parameter in assertions, the reviewer identified that quota_project_id (which defaults to None) must also be included in the assert_called_once_with calls across several test cases to ensure they match the new implementation and pass correctly.
|
Is the x-goog-user-project header getting populated with these changes? |
Mahalaxmibejugam
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes bug 503990490 where AsyncGrpcClient fails to propagate quota_project_id and api_endpoint from ClientOptions to the gRPC channel.