chore(bigframes): fix mypy errors and JSON serialization order#16755
Merged
chalmerlowe merged 1 commit intomainfrom Apr 21, 2026
Merged
chore(bigframes): fix mypy errors and JSON serialization order#16755chalmerlowe merged 1 commit intomainfrom
chalmerlowe merged 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds mypy type ignores to pyarrow.compute.is_null calls and updates JSON test expectations to reflect a change in key ordering. Feedback suggests that adjacent pyarrow.compute.fill_null calls likely require similar type ignores to fully resolve mypy errors. Furthermore, the change in JSON key order in the tests should be reviewed to ensure output stability, ideally by using programmatic sorting for dictionary-like outputs.
daniel-sanche
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes mypy errors regarding pyarrow.compute and a JSON serialization order mismatch in bigframes tests.