chore: specify explicit options for all API paths in librarian.yaml#16762
chore: specify explicit options for all API paths in librarian.yaml#16762jskeet wants to merge 4 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes package names across several Google Cloud Python libraries, updating type marker files, sample installation instructions, and snippet metadata to use consistent package identifiers. It also includes minor import reordering in test files and formatting adjustments in repository metadata. I have no feedback to provide.
jskeet
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
(Having just prototyped the "remove redundant options", the librarian.yaml file will end up being smaller than it is today...) |
jskeet
added
the
do not merge
jskeet
force-pushed
the
explicit-options
branch
from
391d421 to
5cc56ab
Compare
|
Rebased on main so that we don't reinstate the keep lists we removed before. I'm locally running a |
jskeet
removed
the
do not merge
|
#16764 should fix the |
|
Great - will rebase tomorrow UK time and merge when green (assuming the approval sticks) |
This means we don't use the generator default for any of: - python-gapic-name - python-gapic-namespace - warehouse-package-name A later change in librarian will start inferring these options itself, at which point we can remove the options which are then redundant - and new APIs should almost always use the inferred ones.
The changes here are all corrections where previously the package name was incorrect in comments.
(Those packages weren't previously enabled for generation.)
jskeet
force-pushed
the
explicit-options
branch
from
dabc738 to
231872c
Compare
|
@parthea: Looking at the Kokoro logs, I believe these are Spanner failures |
jskeet
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
3 participants
This means we don't use the generator default for any of:
Only API paths which didn't already have an explicit default were updated.
The changes are all from explicitly specifying
warehouse-package-name, and are all corrections from where the generator was inferring the package name incorrectly. (And regenerating Datastore, which wasn't automated in #16737.)This is the first step in googleapis/librarian#5163 - we will then change librarian to use a new approach to inference (deriving the namespace just from the first two components of the API path), and remove all the explicit options which would be inferred the same way. So while this PR adds a lot of lines to the config, many will later be removed again.