Skip to content

chore: remove all explicit transport options#16789

Merged
jskeet merged 1 commit intogoogleapis:mainfrom
jskeet:remove-transport-2
Apr 24, 2026
Merged

chore: remove all explicit transport options#16789
jskeet merged 1 commit intogoogleapis:mainfrom
jskeet:remove-transport-2

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 24, 2026

This does not create any differences after regeneration (because the options are all inferred correctly).

This does not create any differences after regeneration.
@jskeet jskeet requested a review from a team as a code owner April 24, 2026 06:42
@jskeet jskeet requested a review from parthea April 24, 2026 06:42
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes explicit transport configuration settings for numerous Google Cloud APIs within the librarian.yaml file. The review feedback suggests that these changes introduce fragility into the build process by relying on the generator's inference logic rather than explicit definitions. This is particularly concerning for APIs with specific transport requirements, such as those that are REST-only or gRPC-only, and maintaining these explicit settings is recommended for robustness and clarity.

Comment thread librarian.yaml
google/cloud/bigquery/datapolicies/v1:
- python-gapic-namespace=google.cloud
- python-gapic-name=bigquery_datapolicies
- transport=grpc+rest
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While the goal of reducing configuration is understandable, removing explicit transport settings across the file makes the build process more fragile. It relies on the generator's ability to correctly infer the transport for each of the many API versions.

This is particularly risky for APIs with non-standard transports, for example:

  • google/cloud/compute/v1 which is rest-only (line 1361).
  • Several beta versions which are grpc-only, while their v1 counterparts are grpc+rest (e.g., line 996).

If the generator's inference logic changes in the future, it could silently introduce incorrect transport support. Explicitly defining the transport is more robust and self-documenting. It is recommended to revert these changes to maintain explicitness and reduce future maintenance risks.

@jskeet jskeet merged commit daeb931 into googleapis:main Apr 24, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants