Skip to content

chore: disable librarian generation of google-cloud-bigquery temporarily#16813

Merged
chalmerlowe merged 1 commit intogoogleapis:mainfrom
jskeet:disable-bigquery-generation
Apr 27, 2026
Merged

chore: disable librarian generation of google-cloud-bigquery temporarily#16813
chalmerlowe merged 1 commit intogoogleapis:mainfrom
jskeet:disable-bigquery-generation

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 27, 2026

This should be reverted when #16811 fixed.

@jskeet jskeet requested a review from chalmerlowe April 27, 2026 09:59
@jskeet jskeet requested a review from a team as a code owner April 27, 2026 09:59
Copy link
Copy Markdown
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit 5973aba into googleapis:main Apr 27, 2026
30 checks passed
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the BigQuery library configuration in librarian.yaml by adding skip_generate: true. The reviewer suggested adding a TODO comment or a reference to a tracking issue to document the reason for this workaround, which helps with future maintenance and identifies when the change can be reverted.

Comment thread librarian.yaml
is a fully managed, NoOps, low cost data analytics service.
Data can be streamed into BigQuery at millions of rows per second to enable real-time analysis.
With BigQuery you can easily deploy Petabyte-scale Databases.
skip_generate: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For temporary workarounds like this, it is best practice to include a reference to the tracking issue or a TODO comment directly in the configuration file. This ensures that the reason for the skip is visible to future maintainers and makes it easier to identify when the change can be safely reverted.

    # TODO: Revert this when #16811 is fixed.
    skip_generate: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants