Skip to content

Add license information to pyproject.toml#16816

Open
ecederstrand wants to merge 2 commits intogoogleapis:mainfrom
ecederstrand:patch-1
Open

Add license information to pyproject.toml#16816
ecederstrand wants to merge 2 commits intogoogleapis:mainfrom
ecederstrand:patch-1

Conversation

@ecederstrand
Copy link
Copy Markdown

@ecederstrand ecederstrand commented Apr 27, 2026

Add license specifiers according to https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license-and-license-files

This allows automatic license inspection tools like pip-licenses to correctly categorize this package.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #16603 🦕

Add license specifiers according to https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license-and-license-files

This allows automatic license inspection tools like pip-licenses to correctly categorize this package.
@ecederstrand ecederstrand requested a review from a team as a code owner April 27, 2026 12:18
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 27, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds license metadata to the pyproject.toml file for the google-crc32c package. The reviewer suggests using the PEP 621 table format for the license field to ensure better compatibility with various tools and notes that such configuration updates should ideally be applied consistently across all packages in the repository.

Comment thread packages/google-crc32c/pyproject.toml Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some libraries using pyproject.toml do not have explicit license declaration

1 participant