Skip to content

chore: run librarian tidy#16844

Merged
jskeet merged 1 commit intogoogleapis:mainfrom
jskeet:tidy-after-issue
Apr 28, 2026
Merged

chore: run librarian tidy#16844
jskeet merged 1 commit intogoogleapis:mainfrom
jskeet:tidy-after-issue

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 28, 2026

This does not affect generation as only options which would be derived to the same value are removed.

This does not affect generation as only options which would be derived
to the same value are removed.
@jskeet jskeet requested a review from chalmerlowe April 28, 2026 12:53
@jskeet jskeet requested a review from a team as a code owner April 28, 2026 12:53
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@jskeet jskeet marked this pull request as draft April 28, 2026 12:55
@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Apr 28, 2026

Just looking into why there's an addition in the diff at all....

@jskeet jskeet marked this pull request as ready for review April 28, 2026 12:56
@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Apr 28, 2026

Just looking into why there's an addition in the diff at all....

Ah, this was just an option being in the wrong order.

@chalmerlowe
Copy link
Copy Markdown
Contributor

I am not tracking what the end goal is OR why we are doing this. As such I am seeing a variance in how some of these are deleted and I don't know why.

In this example why did all the items in one list get deleted, but only one item in the second list get deleted (even though one of the items (e.g. python-gapic-namespace=google.ads) in the second list matches the item in the first list so it would seem reasonable for to to be deleted)?

Screenshot 2026-04-28 at 10 09 42

@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Apr 28, 2026

Basically, librarian derives python-gapic-namespace and python-gapic-name from the API path, and warehouse-package-name from the package name. (So for example, google.ads is derived in the first case because the path starts with google/ads, but not in the second case because the path starts with google/marketingplatform.) Librarian now always specifies all three to the GAPIC generator, so that whatever the GAPIC generator does by default is irrelevant.

This PR removes any value where it matches the value that would be derived - so basically what we pass to the GAPIC generator is identical but we remove a load of redundant configuration in the file.

@jskeet jskeet merged commit ea4607d into googleapis:main Apr 28, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants