fix: BigFrames respects bq default region#16933
Merged
TrevorBergeron merged 3 commits intomainfrom May 5, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the session initialization to dynamically detect the default BigQuery location via a dry-run query when one isn't explicitly provided. A critical issue was identified in the implementation: query_and_wait does not support dry runs because it attempts to call .result() on the job. It is recommended to use the query method instead and to wrap the temporary BigQuery client in a context manager for proper resource handling.
TrevorBergeron
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
tswast
reviewed
May 5, 2026
| ) as temp_client: | ||
| row_iter = temp_client.query_and_wait( | ||
| "SELECT 1", | ||
| job_config=bigquery.QueryJobConfig(dry_run=True), |
Contributor
There was a problem hiding this comment.
Does dry run actually populate the location info? I suppose it should, but good to double-check.
Contributor
Author
There was a problem hiding this comment.
It does afaict from manual usage and the pre-existing integration test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕