tests: add storagebatchoperations v1 as golden API#16942
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the 'storagebatchoperations' API integration, including the necessary Bazel build configurations, documentation, and generated client library code. The review identified a redundant import in the documentation configuration file, which should be removed to maintain code cleanliness.
Comment on lines
+27
to
+31
| import logging | ||
| import os | ||
| import shlex | ||
| import sys | ||
| import logging |
Contributor
There was a problem hiding this comment.
The import logging statement is redundant. Please remove the duplicate import to keep the codebase clean and avoid redundancy.
Suggested change
| import logging | |
| import os | |
| import shlex | |
| import sys | |
| import logging | |
| import logging | |
| import os | |
| import shlex | |
| import sys |
References
- Remove duplicate lines of code, especially duplicate assertions in tests, to keep the codebase clean and avoid redundancy.
chalmerlowe
approved these changes
May 5, 2026
Contributor
chalmerlowe
left a comment
chalmerlowe
left a comment
There was a problem hiding this comment.
LGTM.
There is an instance of a import logging statement being duplicated. That is prolly in the template somewhere and should ultimately be tracked and fixed, if not here.
parthea
added a commit
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards b/508597813