Skip to content

fix(testutils): Drop support for Python 3.9 #16948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chalmerlowe merged 5 commits into from
May 5, 2026
Merged

fix(testutils): Drop support for Python 3.9 #16948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c2142d
feat(testutils): Update setup.py metadata and python_requires
chalmerlowe May 5, 2026
62a4cc5
feat(testutils): Update Nox sessions to remove old versions
chalmerlowe May 5, 2026
6661745
test(testutils): Update testing constraints to 3.10 and drop 3.9
chalmerlowe May 5, 2026
ad19abe
test(testutils): Add version-scanner pragmas to test fixtures and mod…
chalmerlowe May 5, 2026
866f7a0
fix(testutils): Modernize google-auth minimum bound to >=2.1.0
chalmerlowe May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/google-cloud-testutils/mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[mypy]
python_version = 3.9
python_version = 3.10
exclude = tests/unit/resources/
6 changes: 3 additions & 3 deletions packages/google-cloud-testutils/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
# Error if a python version is missing
nox.options.error_on_missing_interpreters = True

ALL_PYTHON = ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
ALL_PYTHON = ["3.10", "3.11", "3.12", "3.13", "3.14"]
DEFAULT_PYTHON_VERSION = "3.14"
BLACK_VERSION = "black==23.7.0"
BLACK_PATHS = ["test_utils", "setup.py"]
Expand Down Expand Up @@ -128,7 +128,7 @@ def system(session):
"--package-name",
"google-cloud-testutils",
"--constraints-file",
"testing/constraints-3.9.txt",
"testing/constraints-3.10.txt",
)


Expand All @@ -142,7 +142,7 @@ def update_lower_bounds(session):
"--package-name",
"google-cloud-testutils",
"--constraints-file",
"testing/constraints-3.9.txt",
"testing/constraints-3.10.txt",
)


Expand Down
5 changes: 2 additions & 3 deletions packages/google-cloud-testutils/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,16 @@
platforms="Posix; MacOS X; Windows",
include_package_data=True,
install_requires=(
"google-auth >= 0.4.0",
"google-auth >= 2.1.0",
"click>=7.0.0",
"packaging>=22.0",
),
python_requires=">=3.9",
python_requires=">=3.10",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The python_requires update to >=3.10 is correct. However, the classifiers list (lines 68-70) should also be updated to include Programming Language :: Python :: 3.13 and Programming Language :: Python :: 3.14 to maintain consistency with the versions specified in noxfile.py and ensure metadata reflects the supported versions.

References
  1. When updating the minimum supported Python version in runtime checks, ensure that the project's metadata in 'setup.py' or 'pyproject.toml' is also updated to reflect the same minimum version in 'python_requires' and Trove classifiers.
  2. Python 3.14 is a valid Python version and should be supported in configurations.

classifiers=[
"Development Status :: 4 - Beta",
"Intended Audience :: Developers",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
Expand Down
10 changes: 10 additions & 0 deletions packages/google-cloud-testutils/testing/constraints-3.10.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# This constraints file is used to check that lower bounds
# are correct in setup.py
# List *all* library dependencies and extras in this file.
# Pin the version to the lower bound.
#
# e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev",
# Then this file should have foo==1.14.0
click==7.0.0
google-auth==2.1.0
packaging==22.0
10 changes: 0 additions & 10 deletions packages/google-cloud-testutils/testing/constraints-3.9.txt
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/google-cloud-testutils/tests/unit/resources/bad_package/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,5 @@
],
install_requires=requirements,
packages=setuptools.find_packages(),
python_requires=">=3.9",
python_requires=">=3.9", # version-scanner: ignore
Copy link
Copy Markdown
Contributor

@parthea parthea May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we update this rather than ignore it?

)
2 changes: 1 addition & 1 deletion packages/google-cloud-testutils/tests/unit/resources/good_package/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,5 @@
install_requires=requirements,
extras_require=extras,
packages=setuptools.find_packages(),
python_requires=">=3.9",
python_requires=">=3.9", # version-scanner: ignore
)
Loading