Skip to content

test(bigframes): Fix nb test project id injection for 4 examples#17000

Merged
TrevorBergeron merged 2 commits intomainfrom
tbergeron_notebook_test_fixes
May 7, 2026
Merged

test(bigframes): Fix nb test project id injection for 4 examples#17000
TrevorBergeron merged 2 commits intomainfrom
tbergeron_notebook_test_fixes

Conversation

@TrevorBergeron
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes the project ID variable name to PROJECT_ID and adds @param tags for parameterization across several notebooks. Feedback was provided regarding a formatting inconsistency in the @param tag within the remote_function_vertex_claude_model.ipynb notebook to maintain consistency with other files.

…vertex_claude_model.ipynb

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@TrevorBergeron TrevorBergeron requested a review from sycai May 7, 2026 21:53
@TrevorBergeron TrevorBergeron marked this pull request as ready for review May 7, 2026 21:53
@TrevorBergeron TrevorBergeron requested review from a team as code owners May 7, 2026 21:53
@TrevorBergeron TrevorBergeron merged commit 525b2a4 into main May 7, 2026
31 checks passed
@TrevorBergeron TrevorBergeron deleted the tbergeron_notebook_test_fixes branch May 7, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants