Skip to content

chore: remove unused imports#17008

Merged
parthea merged 1 commit into
mainfrom
remove-unused-imports
May 12, 2026
Merged

chore: remove unused imports#17008
parthea merged 1 commit into
mainfrom
remove-unused-imports

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented May 8, 2026

This PR addresses the feedback in #17006 (comment)

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Jinja2 templates for GAPIC generators to prevent unnecessary imports of uuid and re in generated code. By adding a select filter to the check for auto_populated_fields, the templates now correctly identify when these fields are actually present, rather than just checking for the existence of a list of empty values. I have no further feedback to provide.

@parthea parthea marked this pull request as ready for review May 8, 2026 19:43
@parthea parthea requested a review from a team as a code owner May 8, 2026 19:43
@parthea parthea merged commit d6ee72f into main May 12, 2026
89 checks passed
@parthea parthea deleted the remove-unused-imports branch May 12, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants