Skip to content

chore: fix 'multimodel' typo to 'multimodal'#17038

Merged
shuoweil merged 4 commits into
mainfrom
shuowei-fix-multimodal-typo
May 12, 2026
Merged

chore: fix 'multimodel' typo to 'multimodal'#17038
shuoweil merged 4 commits into
mainfrom
shuowei-fix-multimodal-typo

Conversation

@shuoweil
Copy link
Copy Markdown
Contributor

Corrects the typo "multimodel" to "multimodal" across the codebase. This includes internal method names, comments, test functions, and GCS paths in system tests. This aligns the naming with the standard term for models supporting multiple data modalities.

Fixes #<issue_number_goes_here> 🦕

@shuoweil shuoweil requested a review from sycai May 12, 2026 02:45
@shuoweil shuoweil self-assigned this May 12, 2026
@shuoweil shuoweil requested review from a team as code owners May 12, 2026 02:45
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects the spelling of 'multimodal' (previously 'multimodel') across the codebase, including method names, comments, GCS paths, and test functions. Feedback indicates that several test function names were missed in the renaming process, leading to inconsistencies that should be addressed for uniformity across the repository.

Comment thread packages/bigframes/tests/system/large/operations/test_ai.py
Comment thread packages/bigframes/tests/system/large/operations/test_semantics.py
Comment thread packages/bigframes/tests/system/small/bigquery/test_ai.py
Copy link
Copy Markdown
Contributor

@sycai sycai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning this up! The PR LGTM once we reverted that change in CHANGELOG.md


### Bug Fixes

* Deflake ai_gen_bool multimodel test ([#2085](https://github.com/googleapis/python-bigquery-dataframes/issues/2085)) ([566a37a](https://github.com/googleapis/python-bigquery-dataframes/commit/566a37a30ad5677aef0c5f79bdd46bca2139cc1e))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just keep this typo here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted this change.

@shuoweil shuoweil enabled auto-merge (squash) May 12, 2026 17:23
@shuoweil shuoweil requested a review from sycai May 12, 2026 17:23
@shuoweil shuoweil merged commit fbcebd8 into main May 12, 2026
31 checks passed
@shuoweil shuoweil deleted the shuowei-fix-multimodal-typo branch May 12, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants