chore(spanner): skip running tests for archived samples#17059
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a pytest.ini file to the Google Cloud Spanner samples to exclude the archived directory from test discovery. The reviewer noted that the current configuration overwrites pytest's default directory exclusions and recommended including standard defaults like .git and venv to maintain performance and avoid discovery errors.
sakthivelmanii
force-pushed
the
feat-skip-archived-tests
branch
from
c7667f3 to
da6f2d5
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds a pytest.ini configuration file to manage directory recursion during testing. The review feedback highlights a likely redundant directory level in the file path that could interfere with pytest's discovery mechanism. Additionally, there is a suggestion to optimize the norecursedirs configuration by using a wildcard pattern for hidden directories to ensure better coverage and a more concise configuration.
sakthivelmanii
force-pushed
the
feat-skip-archived-tests
branch
from
da6f2d5 to
2a298d1
Compare
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/google-cloud-python/issues) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
2 participants
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕