Skip to content

feat(bigframes): Add ai_generate functions to the dataframe bq accessor#17302

Merged
sycai merged 2 commits into
mainfrom
sycai_pandas_ai
May 29, 2026
Merged

feat(bigframes): Add ai_generate functions to the dataframe bq accessor#17302
sycai merged 2 commits into
mainfrom
sycai_pandas_ai

Conversation

@sycai
Copy link
Copy Markdown
Contributor

@sycai sycai commented May 28, 2026

internal issue: b/517233441

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces AI generation accessor methods (generate, generate_bool, generate_int, and generate_double) to the AbstractBigQueryDataFrameAccessor class, along with corresponding unit tests. The feedback highlights a critical issue in several of the new unit tests where a mocked bpd.DataFrame is used, causing the tests to pass silently without actually executing the accessor code. It is recommended to use a real bpd.DataFrame fixture, such as scalar_types_df, to ensure the accessor implementations are properly exercised and verified.

Comment thread packages/bigframes/tests/unit/core/compile/sqlglot/test_dataframe_accessor.py Outdated
Comment thread packages/bigframes/tests/unit/core/compile/sqlglot/test_dataframe_accessor.py Outdated
Comment thread packages/bigframes/tests/unit/core/compile/sqlglot/test_dataframe_accessor.py Outdated
Comment thread packages/bigframes/tests/unit/core/compile/sqlglot/test_dataframe_accessor.py Outdated
@sycai sycai requested a review from tswast May 28, 2026 22:38
@sycai sycai marked this pull request as ready for review May 28, 2026 22:39
@sycai sycai requested review from a team as code owners May 28, 2026 22:39
@sycai sycai requested a review from TrevorBergeron May 29, 2026 17:44
@sycai sycai merged commit 6b62cb6 into main May 29, 2026
31 checks passed
@sycai sycai deleted the sycai_pandas_ai branch May 29, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants