Skip to content

Actually **stopping** the Pub / Sub consumer on an exception. #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 1 commit into from
Nov 30, 2017
Merged

Actually **stopping** the Pub / Sub consumer on an exception. #4498

dhermes merged 1 commit into from
Nov 30, 2017

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Nov 29, 2017

Fixes #4463.

@dhermes dhermes added api: pubsub Issues related to the Pub/Sub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 29, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 29, 2017
dhermes
dhermes commented Nov 29, 2017
View reviewed changes
pubsub/google/cloud/pubsub_v1/subscriber/_consumer.py
self.stop_consuming()
except Exception as exc:
self.active = self._policy.on_exception(exc)
recover = self._policy.on_exception(exc)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

pubsub/google/cloud/pubsub_v1/subscriber/_helper_threads.py
# We return and stop short of ``pop()``-ing so that the
# thread that invoked the current helper can properly stop
# it.
return

This comment was marked as spam.

Sign in to view

lukesneeringer
lukesneeringer approved these changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@lukesneeringer lukesneeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks correct.

@dhermes dhermes merged commit 9f3cee7 into googleapis:master Nov 30, 2017
@dhermes dhermes deleted the fix-4463-more branch November 30, 2017 00:02
@dhermes dhermes mentioned this pull request Nov 30, 2017
Closed
@dhermes dhermes mentioned this pull request Dec 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lukesneeringer lukesneeringer lukesneeringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

@theacodes theacodes

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhermes @lukesneeringer @tseaver @theacodes @googlebot