Skip to content

Use the rpc's status to determine when to exit the request generator thread#5054

Merged
lukesneeringer merged 2 commits into
googleapis:masterfrom
theacodes:pubsub-request-queue
Mar 20, 2018
Merged

Use the rpc's status to determine when to exit the request generator thread#5054
lukesneeringer merged 2 commits into
googleapis:masterfrom
theacodes:pubsub-request-queue

Conversation

@theacodes
Copy link
Copy Markdown
Contributor

@theacodes theacodes commented Mar 16, 2018

No description provided.

@theacodes theacodes added the api: pubsub Issues related to the Pub/Sub API. label Mar 16, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2018
@theacodes
Copy link
Copy Markdown
Contributor Author

theacodes commented Mar 16, 2018

/cc @nathanielmanistaatgoogle

@chemelnucfin
Copy link
Copy Markdown
Contributor

chemelnucfin commented Mar 16, 2018

@jonparrott Could the _RequestQueueGenerator be in api_core?

@theacodes
Copy link
Copy Markdown
Contributor Author

theacodes commented Mar 16, 2018

@chemelnucfin possibly, but we should only promote it there once we need to.

@theacodes theacodes mentioned this pull request Mar 16, 2018
Closed
tseaver
tseaver reviewed Mar 16, 2018
View reviewed changes
Comment thread pubsub/google/cloud/pubsub_v1/subscriber/_consumer.py
for response in rpc:
print(response)
q.put(...)
"""

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread pubsub/google/cloud/pubsub_v1/subscriber/_consumer.py
"""
with self._put_lock:
self._request_queue.put(request)
self._request_queue.put(request)

This comment was marked as spam.

Sign in to view

Comment thread pubsub/google/cloud/pubsub_v1/subscriber/_consumer.py
request_generator = _RequestQueueGenerator(
self._request_queue, initial_request=initial_request)
rpc = policy.call_rpc(request_generator)
request_generator.rpc = rpc

This comment was marked as spam.

Sign in to view

Comment thread pubsub/google/cloud/pubsub_v1/subscriber/_consumer.py
if self.rpc is not None and not self.rpc.is_active():
return True
else:
return False

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread pubsub/tests/system.py
assert callback.calls >= 2

subscription.close()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This was referenced Mar 19, 2018
Closed
Closed
@tseaver
Copy link
Copy Markdown
Contributor

tseaver commented Mar 19, 2018

LGTM if you add the docstrings for the arguments to _RequestQueueGenerator.

@lukesneeringer
Copy link
Copy Markdown
Contributor

lukesneeringer commented Mar 20, 2018

I ran this for several hours without issue. Merging.

@lukesneeringer lukesneeringer merged commit 3e75cb3 into googleapis:master Mar 20, 2018
@theacodes theacodes mentioned this pull request Mar 21, 2018
Closed
parthea pushed a commit that referenced this pull request Mar 2, 2026
@lukesneeringer
Use the rpc's status to determine when to exit the request generator …
5f02058 
…thread (#5054)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

1 more reviewer

@tseaver tseaver tseaver left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@theacodes @chemelnucfin @tseaver @lukesneeringer @googlebot