Skip to content

Make the pausable response iterator aware of the RPC state to prevent deadlock#5108

Merged
theacodes merged 3 commits into
googleapis:masterfrom
theacodes:fix-pubsub-pausing-consumer
Mar 26, 2018
Merged

Make the pausable response iterator aware of the RPC state to prevent deadlock#5108
theacodes merged 3 commits into
googleapis:masterfrom
theacodes:fix-pubsub-pausing-consumer

Conversation

@theacodes
Copy link
Copy Markdown
Contributor

Closes #5103

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2018
Copy link
Copy Markdown
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

types.
can_continue (threading.Event): An event which determines if we
can advance to the next iteration. Will be ``wait()``-ed on
before

This comment was marked as spam.

This comment was marked as spam.

@theacodes theacodes merged commit 6274007 into googleapis:master Mar 26, 2018
@theacodes theacodes deleted the fix-pubsub-pausing-consumer branch March 26, 2018 19:46
parthea pushed a commit that referenced this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants