-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add scheduler #5230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+175
−0
Merged
Add scheduler #5230
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| # Copyright 2018, Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Schedulers provide means to *schedule* callbacks asynchronously. | ||
|
|
||
| These are used by the subscriber to call the user-provided callback to process | ||
| each message. | ||
| """ | ||
|
|
||
| import abc | ||
| import concurrent.futures | ||
| import sys | ||
|
|
||
| import six | ||
| from six.moves import queue | ||
|
|
||
|
|
||
| @six.add_metaclass(abc.ABCMeta) | ||
| class Scheduler(object): | ||
| """Abstract base class for schedulers. | ||
|
|
||
| Schedulers are used to schedule callbacks asynchronously. | ||
| """ | ||
|
|
||
| @property | ||
| @abc.abstractmethod | ||
| def queue(self): | ||
| """Queue: A concurrency-safe queue specific to the underlying | ||
| concurrency implementation. | ||
|
|
||
| This queue is used to send messages *back* to the scheduling actor. | ||
| """ | ||
| raise NotImplementedError | ||
|
|
||
| @abc.abstractmethod | ||
| def schedule(self, callback, *args, **kwargs): | ||
| """Schedule the callback to be called asynchronously. | ||
|
|
||
| Args: | ||
| callback (Callable): The function to call. | ||
| args: Positional arguments passed to the function. | ||
| kwargs: Key-word arguments passed to the function. | ||
|
|
||
| Returns: | ||
| None | ||
| """ | ||
| raise NotImplementedError | ||
|
|
||
| @abc.abstractmethod | ||
| def shutdown(self): | ||
| """Shuts down the scheduler and immediately end all pending callbacks. | ||
| """ | ||
| raise NotImplementedError | ||
|
|
||
|
|
||
| def _make_default_thread_pool_executor(): | ||
| # Python 2.7 and 3.6+ have the thread_name_prefix argument, which is useful | ||
| # for debugging. | ||
| executor_kwargs = {} | ||
| if sys.version_info[:2] == (2, 7) or sys.version_info >= (3, 6): | ||
| executor_kwargs['thread_name_prefix'] = ( | ||
| 'ThreadPoolExecutor-ThreadScheduler') | ||
| return concurrent.futures.ThreadPoolExecutor( | ||
| max_workers=10, | ||
| **executor_kwargs | ||
| ) | ||
|
|
||
|
|
||
| class ThreadScheduler(object): | ||
| """A thread pool-based scheduler. | ||
|
|
||
| This scheduler is useful in typical I/O-bound message processing. | ||
|
|
||
| Args: | ||
| executor(concurrent.futures.ThreadPoolExecutor): An optional executor | ||
| to use. If not specified, a default one will be created. | ||
| """ | ||
| def __init__(self, executor=None): | ||
| self._queue = queue.Queue() | ||
| if executor is None: | ||
| self._executor = _make_default_thread_pool_executor() | ||
| else: | ||
| self._executor = executor | ||
|
|
||
| @property | ||
| def queue(self): | ||
| """Queue: A thread-safe queue used for communication between callbacks | ||
| and the scheduling thread.""" | ||
| return self._queue | ||
|
|
||
| def schedule(self, callback, *args, **kwargs): | ||
| """Schedule the callback to be called asynchronously in a thread pool. | ||
|
|
||
| Args: | ||
| callback (Callable): The function to call. | ||
| args: Positional arguments passed to the function. | ||
| kwargs: Key-word arguments passed to the function. | ||
|
|
||
| Returns: | ||
| None | ||
| """ | ||
| self._executor.submit(callback, *args, **kwargs) | ||
|
|
||
| def shutdown(self): | ||
| """Shuts down the scheduler and immediately end all pending callbacks. | ||
| """ | ||
| # Drop all pending item from the executor. Without this, the executor | ||
| # will block until all pending items are complete, which is | ||
| # undesirable. | ||
| self._executor._work_queue.queue.clear() | ||
| self._executor.shutdown() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # Copyright 2018, Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import concurrent.futures | ||
| import threading | ||
|
|
||
| import mock | ||
| from six.moves import queue | ||
|
|
||
| from google.cloud.pubsub_v1.subscriber import scheduler | ||
|
|
||
|
|
||
| def test_constructor_defaults(): | ||
| scheduler_ = scheduler.ThreadScheduler() | ||
|
|
||
| assert isinstance(scheduler_.queue, queue.Queue) | ||
| assert isinstance(scheduler_._executor, concurrent.futures.Executor) | ||
|
|
||
|
|
||
| def test_constructor_options(): | ||
| scheduler_ = scheduler.ThreadScheduler( | ||
| executor=mock.sentinel.executor) | ||
|
|
||
| assert scheduler_._executor == mock.sentinel.executor | ||
|
|
||
|
|
||
| def test_schedule(): | ||
| called_with = [] | ||
| called = threading.Event() | ||
|
|
||
| def callback(*args, **kwargs): | ||
| called_with.append((args, kwargs)) | ||
| called.set() | ||
|
|
||
| scheduler_ = scheduler.ThreadScheduler() | ||
|
|
||
| scheduler_.schedule(callback, 'arg1', kwarg1='meep') | ||
|
|
||
| called.wait() | ||
| scheduler_.shutdown() | ||
|
|
||
| assert called_with == [(('arg1',), {'kwarg1': 'meep'})] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.