BigQuery: add UnknownJob type for redacted jobs.#5281
Merged
tswast merged 1 commit intogoogleapis:masterfrom May 1, 2018
Merged
BigQuery: add UnknownJob type for redacted jobs.#5281tswast merged 1 commit intogoogleapis:masterfrom
tswast merged 1 commit intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Contributor
|
I can't see any benefit to the caller in getting back an instance of That said, I don't see an issue with the code here, so feel free to merge if the consensus is agin' me. |
Contributor
Author
|
We had a meeting with the BQ backend team this morning, and this was the conclusion / compromise. My opinion is the backend should return a 403 on permissions errors rather than redacting, but that's still an ongoing conversation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5220
/cc @shollyman