Fix retrying of bidirectional RPCs and closing the streaming pull manager#5412
Merged
Merged
Conversation
googlebot
added
the
cla: yes
crwilcox
approved these changes
May 30, 2018
sjagoe
reviewed
May 31, 2018
| # If this is in the list of idempotent exceptions, then we want to | ||
| # recover. | ||
| if isinstance(exception, _RETRYABLE_STREAM_ERRORS): | ||
| logging.info('Observed recoverable stream error %s', exception) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
No, I just noticed this myself. Will fix asap.
…On Thu, May 31, 2018, 12:43 AM Simon Jagoe ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
pubsub/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py
<#5412 (comment)>
:
> @@ -414,11 +415,28 @@ def _should_recover(self, exception):
# If this is in the list of idempotent exceptions, then we want to
# recover.
if isinstance(exception, _RETRYABLE_STREAM_ERRORS):
+ logging.info('Observed recoverable stream error %s', exception)
Are these log messages intentionally using the root logger?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#5412 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc9JFAxFa-_Qmk3qKsit3v7D42DpSks5t3586gaJpZM4UTqlB>
.
|
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5306