Skip to content

Conversation

@crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Apr 1, 2019

This pull request was generated using releasetool.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2019
@crwilcox crwilcox requested review from jeanbza and tseaver April 1, 2019 18:47
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2019
@crwilcox
Copy link
Contributor Author

crwilcox commented Apr 1, 2019

System Tests seems to have a real failure that will need addressing :(

_______________________________ test_watch_query _______________________________
client = <google.cloud.firestore_v1.client.Client object at 0x7ff3dfa99208>
cleanup = <built-in method append of list object at 0x7ff3dc29b788>
    def test_watch_query(client, cleanup):
        db = client
        doc_ref = db.collection(u"users").document(u"alovelace" + unique_resource_id())
        query_ref = db.collection(u"users").where("first", "==", u"Ada")
        # Initial setting
        doc_ref.set({u"first": u"Jane", u"last": u"Doe", u"born": 1900})
        sleep(1)
        # Setup listener
        def on_snapshot(docs, changes, read_time):
            on_snapshot.called_count += 1
            # A snapshot should return the same thing as if a query ran now.
            query_ran = db.collection(u"users").where("first", "==", u"Ada").stream()
            assert len(docs) == len([i for i in query_ran])
        on_snapshot.called_count = 0
        query_ref.on_snapshot(on_snapshot)
        # Alter document
        doc_ref.set({u"first": u"Ada", u"last": u"Lovelace", u"born": 1815})
        for _ in range(10):
            if on_snapshot.called_count == 1:
                return
            sleep(1)
        if on_snapshot.called_count != 1:
            raise AssertionError(
                "Failed to get exactly one document change: count: "
>               + str(on_snapshot.called_count)
            )
E           AssertionError: Failed to get exactly one document change: count: 0
tests/system.py:834: AssertionError
------------------------------ Captured log call -------------------------------
bidi.py                    561 ERROR    Thread-ConsumeBidirectionalStream caught unexpected exception Error 3:  Document parent name "projects/abstract-disk-227418/databases/(default)" lacks "/" at index 49. and will exit.
Traceback (most recent call last):
  File "/tmpfs/src/github/google-cloud-python/api_core/google/api_core/bidi.py", line 545, in _thread_main
    self._on_response(response)
  File "/tmpfs/src/github/google-cloud-python/firestore/google/cloud/firestore_v1/watch.py", line 442, in on_snapshot
    meth(proto)
  File "/tmpfs/src/github/google-cloud-python/firestore/google/cloud/firestore_v1/watch.py", line 397, in _on_snapshot_target_change_remove
    raise RuntimeError(message)
RuntimeError: Error 3:  Document parent name "projects/abstract-disk-227418/databases/(default)" lacks "/" at index 49.

@crwilcox crwilcox force-pushed the release-firestore-0.32.0 branch from 7a46790 to 847d5bb Compare April 2, 2019 22:45
@crwilcox crwilcox merged commit 4b3348e into master Apr 2, 2019
@yoshi-automation
Copy link
Contributor

@yoshi-automation
Copy link
Contributor

The release build has started, the log can be viewed here. 🌻

@yoshi-automation
Copy link
Contributor

🥚 You hatched a release! The release build finished successfully! 💜

@busunkim96 busunkim96 deleted the release-firestore-0.32.0 branch April 26, 2019 17:16
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorelease: published cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants