Allow override of KMS keys in storage acceptance tests#2528
Merged
quartzmo merged 3 commits intogoogleapis:masterfrom Oct 18, 2018
Merged
Allow override of KMS keys in storage acceptance tests#2528quartzmo merged 3 commits intogoogleapis:masterfrom
quartzmo merged 3 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
blowmage
reviewed
Oct 17, 2018
| let(:kms_key) { "projects/helical-zone-771/locations/#{bucket_location}/keyRings/ruby-test/cryptoKeys/ruby-test-key-1" } | ||
| let(:kms_key_2) { "projects/helical-zone-771/locations/#{bucket_location}/keyRings/ruby-test/cryptoKeys/ruby-test-key-2" } | ||
| let(:kms_key) { | ||
| ENV["GCLOUD_RUBY_TEST_KEY_1"] || |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
blowmage
reviewed
Oct 18, 2018
| let(:kms_key_2) { "projects/helical-zone-771/locations/#{bucket_location}/keyRings/ruby-test/cryptoKeys/ruby-test-key-2" } | ||
| let(:kms_key) { | ||
| ENV["GCLOUD_TEST_STORAGE_KMS_KEY_1"] || | ||
| "projects/helical-zone-771/locations/#{bucket_location}/keyRings/ruby-test/cryptoKeys/ruby-test-key-1" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
blowmage
approved these changes
Oct 18, 2018
blowmage
added
api: storage
quartzmo
approved these changes
Oct 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Access to the keys currently hard-coded in the tests, may be restricted when tests are run from a VPC project. These changes allow tests to be invoked with a different set of keys, which will unblock the Cloud testing team from running the affected tests in a restricted environment.
See #2518