Allow overriding storage bucket in acceptance tests#2531
Merged
quartzmo merged 1 commit intogoogleapis:masterfrom Oct 19, 2018
Merged
Allow overriding storage bucket in acceptance tests#2531quartzmo merged 1 commit intogoogleapis:masterfrom
quartzmo merged 1 commit intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
quartzmo
approved these changes
Oct 19, 2018
Member
There was a problem hiding this comment.
This LGTM and I can merge now without delay if needed.
However, I am just wondering for the sake of consistency and reducing duplication if you want to follow the design in #2522 and refactor these two calls to ENV to the assignment of a single global variable as was done in bigquery_helper.rb?
Contributor
Author
|
@quartzmo Honestly, I don't think these are worth the extra layer of design. These are all kind of one-offs right now, to unblock specific test scenarios from the storage team. And anyway, if we do get to a point where we have more than 2-3ish test scenarios and really need to manage our test datasets, we should probably employ a unified system for that, rather than a bunch of ad hoc environment variables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Access to the bucket currently hard-coded in the tests, may be restricted when tests are run from a VPC project. These changes allow tests to be invoked with a different bucket, which will unblock the Cloud testing team from running the affected tests in a restricted environment.
See #2522