Skip to content

chore(storage): Migrate to google-cloud-pubsub v3.x#30773

Merged
aandreassa merged 2 commits intomainfrom
storage-pubsubv3-fix
Aug 6, 2025
Merged

chore(storage): Migrate to google-cloud-pubsub v3.x#30773
aandreassa merged 2 commits intomainfrom
storage-pubsubv3-fix

Conversation

@aandreassa
Copy link
Copy Markdown
Contributor

No description provided.

@aandreassa aandreassa marked this pull request as ready for review August 6, 2025 23:14
@aandreassa aandreassa requested review from a team August 6, 2025 23:14
dazuma
dazuma previously approved these changes Aug 6, 2025
Copy link
Copy Markdown
Contributor

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one nit

Comment thread google-cloud-storage/samples/acceptance/notification_test.rb Outdated
Copy link
Copy Markdown
Contributor

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the conventional commit message to something other than fix:, since the library itself hasn't changed (and doesn't need a rerelease), but only sample tests have been changed.

@aandreassa aandreassa changed the title fix(storage): Migrate to google-cloud-pubsub v3.x chore(storage): Migrate to google-cloud-pubsub v3.x Aug 6, 2025
@aandreassa aandreassa merged commit 47c827a into main Aug 6, 2025
14 of 15 checks passed
@aandreassa aandreassa deleted the storage-pubsubv3-fix branch August 6, 2025 23:46
@github-actions github-actions Bot added the release-please:force-run To run release-please label Aug 7, 2025
@release-please release-please Bot removed the release-please:force-run To run release-please label Aug 7, 2025
shubhangi-google pushed a commit to shubhangi-google/google-cloud-ruby that referenced this pull request Aug 25, 2025
shubhangi-google pushed a commit to shubhangi-google/google-cloud-ruby that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants