feat(generator/rust): enums with bad defaults#1389
Merged
coryan merged 1 commit intogoogleapis:mainfrom Feb 27, 2025
Merged
Conversation
Initialize enums with no obvious default to the empty string. None of the Google Cloud enums need this, but we will use it to generate `google.protobuf.ProtoDescriptor`.
dbolduc
approved these changes
Feb 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 37 37
Lines 1462 1462
=======================================
Hits 1403 1403
Misses 59 59 ☔ View full report in Codecov by Sentry. |
coryan
deleted the
feat-generator-rust-support-enums-with-no-obvious-default
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize enums with no obvious default to the empty string. None of
the Google Cloud enums need this, but we will use it to generate
google.protobuf.ProtoDescriptor.Part of the work for #37