Skip to content

feat(wkt): convert to Prost's version of the WKT#1420

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-wkt-convert-to-and-from-prost-types
Mar 7, 2025
Merged

feat(wkt): convert to Prost's version of the WKT#1420
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-wkt-convert-to-and-from-prost-types

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Mar 6, 2025

We will need to convert to and from Prost's versions of the well-known
types. The same trait will be used to convert between our generated
types and the types that Prost generates.

Part of the work for #1384

We will need to convert to and from Prost's versions of the well-known
types. The same trait will be used to convert between our generated
types and the types that Prost generates.
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 6 lines in your changes missing coverage. Please review.

Project coverage is 95.74%. Comparing base (0644e87) to head (b1bc202).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/wkt/src/prost.rs 88.23% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1420      +/-   ##
==========================================
- Coverage   96.00%   95.74%   -0.26%     
==========================================
  Files          37       38       +1     
  Lines        1477     1528      +51     
==========================================
+ Hits         1418     1463      +45     
- Misses         59       65       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review March 6, 2025 20:43
@coryan coryan requested review from codyoss and dbolduc March 6, 2025 20:43
@coryan coryan merged commit 9c1da1d into googleapis:main Mar 7, 2025
20 checks passed
@coryan coryan deleted the feat-wkt-convert-to-and-from-prost-types branch March 7, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants