Skip to content

fix(auth): Read token_uri from user json#1430

Merged
sai-sunder-s merged 3 commits intogoogleapis:mainfrom
sai-sunder-s:tokenuri
Mar 10, 2025
Merged

fix(auth): Read token_uri from user json#1430
sai-sunder-s merged 3 commits intogoogleapis:mainfrom
sai-sunder-s:tokenuri

Conversation

@sai-sunder-s
Copy link
Contributor

If token_uri is provided in the json, we should use that instead of a hardcoded value.

@sai-sunder-s sai-sunder-s requested review from coryan and dbolduc March 7, 2025 23:51
@codecov
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.74%. Comparing base (b3ae1f9) to head (053a590).
Report is 240 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1430       +/-   ##
===========================================
- Coverage   95.89%   66.74%   -29.16%     
===========================================
  Files          34       39        +5     
  Lines        1365     2195      +830     
===========================================
+ Hits         1309     1465      +156     
- Misses         56      730      +674     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see a new test for the new functionality. Is it possible to write one?

@sai-sunder-s sai-sunder-s added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 10, 2025
@sai-sunder-s sai-sunder-s merged commit 4022325 into googleapis:main Mar 10, 2025
20 checks passed
@sai-sunder-s sai-sunder-s deleted the tokenuri branch April 3, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run Add this label to force Kokoro to re-run the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants