fix(auth): Read token_uri from user json#1430
Merged
sai-sunder-s merged 3 commits intogoogleapis:mainfrom Mar 10, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1430 +/- ##
===========================================
- Coverage 95.89% 66.74% -29.16%
===========================================
Files 34 39 +5
Lines 1365 2195 +830
===========================================
+ Hits 1309 1465 +156
- Misses 56 730 +674 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
reviewed
Mar 8, 2025
coryan
reviewed
Mar 8, 2025
Collaborator
coryan
left a comment
There was a problem hiding this comment.
I would like to see a new test for the new functionality. Is it possible to write one?
coryan
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If token_uri is provided in the json, we should use that instead of a hardcoded value.