Skip to content

feat(wkt): NullValue behaves like enums#1485

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-wkt-null-value-is-more-enum-like
Mar 13, 2025
Merged

feat(wkt): NullValue behaves like enums#1485
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-wkt-null-value-is-more-enum-like

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Mar 13, 2025

In some contexts it is useful if NullValue behaves more like an enum.
Protobuf defines it as an enum, and the generator produces code assuming
it has the interface defined for enums.

Part of the work for #1384

In some contexts it is useful if `NullValue` behaves more like an enum.
Protobuf defines it as an enum, and the generator produces code assuming
it has the interface defined for enums.
@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (4040e0b) to head (259860d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
+ Coverage   95.87%   95.95%   +0.07%     
==========================================
  Files          38       38              
  Lines        1526     1531       +5     
==========================================
+ Hits         1463     1469       +6     
+ Misses         63       62       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review March 13, 2025 13:22
@coryan coryan merged commit 1881ff0 into googleapis:main Mar 13, 2025
20 checks passed
@coryan coryan deleted the feat-wkt-null-value-is-more-enum-like branch March 13, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants