Skip to content

refactor!: move param helpers to g-c-http-client#1507

Merged
coryan merged 2 commits intogoogleapis:mainfrom
coryan:move-gax-reqwest-client-pr7
Mar 14, 2025
Merged

refactor!: move param helpers to g-c-http-client#1507
coryan merged 2 commits intogoogleapis:mainfrom
coryan:move-gax-reqwest-client-pr7

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Mar 14, 2025

The parameter helpers are only used by HTTP+JSON clients, and then only
as implementation details.

Part of the work for #1490

coryan added 2 commits March 14, 2025 16:28
The parameter helpers are only used by HTTP+JSON clients, and then only
as implementation details.
@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (e66ce91) to head (3663d15).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1507   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          38       38           
  Lines        1576     1576           
=======================================
  Hits         1503     1503           
  Misses         73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review March 14, 2025 20:51
@coryan coryan requested review from codyoss and dbolduc March 14, 2025 20:51
@coryan coryan merged commit b6c1936 into googleapis:main Mar 14, 2025
20 checks passed
@coryan coryan deleted the move-gax-reqwest-client-pr7 branch March 14, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants