Skip to content

cleanup!: hide PageableResponse trait#1666

Merged
dbolduc merged 2 commits intogoogleapis:mainfrom
dbolduc:hide-pageable-response
Mar 31, 2025
Merged

cleanup!: hide PageableResponse trait#1666
dbolduc merged 2 commits intogoogleapis:mainfrom
dbolduc:hide-pageable-response

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Mar 31, 2025

Part of the work for #1609

Move PageableResponse to an internal module, and hide it from the docs.

When an RPC is paginated, we generate a paginator() method on the builder. Applications do not care that a message is a PageableResponse.

Note that in the future we will hide Paginator construction (currently, Paginator::new()) from applications as well.

@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (78c6bca) to head (c9c2354).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1666   +/-   ##
=======================================
  Coverage   96.03%   96.03%           
=======================================
  Files          47       47           
  Lines        1890     1890           
=======================================
  Hits         1815     1815           
  Misses         75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc marked this pull request as ready for review March 31, 2025 20:28
@dbolduc dbolduc merged commit a8e558c into googleapis:main Mar 31, 2025
20 checks passed
@dbolduc dbolduc deleted the hide-pageable-response branch March 31, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants