Conversation
|
|
||
| Note that a client built `from_stub()` does not have an internal retry loop. It | ||
| returns all errors from the stub directly to the application. | ||
|
|
There was a problem hiding this comment.
In other sections I link the full function for each sub-section separately. Consider doing the same here.
There was a problem hiding this comment.
Um, I think I will pass. The tests have shared code, so I do not think the sub-sections would actually be "full".
There was a problem hiding this comment.
Um, I think I will pass. The tests have shared code, so I do not think the sub-sections would actually be "full".
Strike this. I just realized we can have an anchor in multiple places, and mdbook will concatenate the sections. e.g.
// ANCHOR: foo
1
// ANCHOR_END: foo
2
3
4
// ANCHOR: foo
5
// ANCHOR_END: foo
yields:
1
5
So I am out of excuses. Will clean this up soon-ish.
There was a problem hiding this comment.
Nevermind. The mdbook behavior I described is totally unreliable. :(
There was a problem hiding this comment.
totally unreliable
Lol, I finally understand...
{{#include ... }} will not concatenate sections with the same marker.
{{#rustdoc_include ... }} will concatenate sections with the same marker.
I was switching between the two unreliably.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
=======================================
Coverage 95.94% 95.94%
=======================================
Files 47 47
Lines 1850 1850
=======================================
Hits 1775 1775
Misses 75 75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Follow-up to #1654
I felt this did not go without saying, so I said it.